Skip to content

register: add mconfigptr register #290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 4, 2025

Conversation

rmsyn
Copy link
Contributor

@rmsyn rmsyn commented May 18, 2025

Adds the definition for the mconfigptr Machine configuration pointer CSR.

Adds basic unit tests for the mconfigptr CSR.

@rmsyn rmsyn requested a review from a team as a code owner May 18, 2025 02:06
@rmsyn rmsyn force-pushed the riscv/register/mconfigptr branch 5 times, most recently from 1ecf7cf to f267697 Compare May 18, 2025 03:52
Copy link
Contributor

@romancardenas romancardenas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@romancardenas romancardenas enabled auto-merge May 19, 2025 21:01
romancardenas
romancardenas previously approved these changes Jun 2, 2025
Copy link
Contributor

@romancardenas romancardenas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@romancardenas
Copy link
Contributor

@rmsyn please fix conflicts

@rmsyn rmsyn force-pushed the riscv/register/mconfigptr branch from f267697 to 71ca782 Compare June 3, 2025 03:02
@romancardenas romancardenas disabled auto-merge June 3, 2025 06:18
@romancardenas
Copy link
Contributor

Not sure what happened, but it looks like there are still conflicts pending

rmsyn added 3 commits June 3, 2025 17:19
Adds the definition for the `mconfigptr` Machine configuration pointer
CSR.
Adds basic unit tests for the `mconfigptr` CSR.
Bumps the MSRV to 1.67.0 for the name change of the integer log
functions from `log` to `ilog` variants.
@rmsyn
Copy link
Contributor Author

rmsyn commented Jun 4, 2025

Not sure what happened, but it looks like there are still conflicts pending

Looks like I rebased on a stale master checkout. Fixed now.

@romancardenas romancardenas added this pull request to the merge queue Jun 4, 2025
Merged via the queue into rust-embedded:master with commit 2c5b62c Jun 4, 2025
138 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants